-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update to Wasp 0.20 #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Wasp 0.20 #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the package lock with deps from wasp start, wasp build and ran npm dedupe
| "@aws-sdk/s3-presigned-post": "^3.750.0", | ||
| "@aws-sdk/s3-request-presigner": "^3.523.0", | ||
| "@google-analytics/data": "4.1.0", | ||
| "@headlessui/react": "1.7.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with Vinny. This and headlessui are just leftovers from the redesign
| "clsx": "^2.1.1", | ||
| "headlessui": "^0.0.0", | ||
| "lucide-react": "^0.525.0", | ||
| "node-fetch": "3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore since we have a minimum of Node 22
template/app/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@faker-js/faker": "8.3.1", | ||
| "@testing-library/react": "^16.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It complained that we didn't have this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check with @sodic if he saw this before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this section in the migration guide: https://wasp-docs-on-main.pages.dev/docs/migration-guides/migrate-from-0-19-to-0-20#4-update-your-app-to-work-with-testing-libraryreact-16xx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't think you need it in the package.json. How did it complain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it again, npm only complained on the first resolution, when it stil had a mix of the new package.json but old package-lock.json. It doesn't complain on the following ones, and seems to resolve fine.
Undoing the change.
| env: | ||
| WASP_TELEMETRY_DISABLE: 1 | ||
| WASP_VERSION: 0.19.0 | ||
| WASP_VERSION: 0.20.0-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we update this back to 0.20.0 after the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we would but I'm moving OpenSaaS to use main so it'd be moot
infomiho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI passes, good enough for me
Description
Update to Wasp 0.20
Contributor Checklist