Skip to content

Conversation

@karheda
Copy link

@karheda karheda commented Dec 1, 2025

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
Issues Fix #2567
License MIT

@karheda karheda requested a review from Kocal as a code owner December 1, 2025 10:39
@carsonbot carsonbot added Bug Bug Fix Deprecation Documentation Improvements or additions to documentation Feature New Feature Status: Needs Review Needs to be reviewed labels Dec 1, 2025
@carsonbot carsonbot changed the title Dropzone multiple uploads Dropzone multiple uploads Dec 1, 2025
@karheda karheda changed the title Dropzone multiple uploads [Dropzone] Dropzone multiple uploads Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Dropzone
controller.d.ts 723 B / 337 B 958 B+33% 📈 / 425 B+26% 📈
controller.js 2.92 kB / 819 B 4.43 kB+52% 📈 / 1.34 kB+67% 📈
style.min.css 944 B / 468 B 959 B+2% 📈 / 472 B+1% 📈

@karheda
Copy link
Author

karheda commented Dec 1, 2025

Hi @Kocal I had to create new PR, because I couldn't change my default branch from 2.x to dropzone-multiple-uploads branch in the previews PR. We can close the preview PR. Now we have to solve 3 failing checks of PHP too. Could you tell me if I have made the changes well?
Thank you!

Carlos Hernández added 16 commits December 1, 2025 12:11
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.
…d UI logic for preview visibility and structure.
…coverage, and adjust styles.

# Conflicts:
#	src/Dropzone/assets/dist/controller.js
#	src/Dropzone/assets/src/controller.ts
#	src/Dropzone/assets/test/unit/controller.test.ts
#	src/Dropzone/assets/test/vitest.setup.js
#	src/Dropzone/assets/vitest.config.mjs
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.

# Conflicts:
#	src/Dropzone/CHANGELOG.md
#	src/Dropzone/assets/src/controller.ts
… files.

# Conflicts:
#	src/Dropzone/assets/src/controller.ts
…d UI logic for preview visibility and structure.

# Conflicts:
#	src/Dropzone/assets/test/unit/controller.test.ts
#	src/Dropzone/templates/form_theme.html.twig
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.
@karheda karheda force-pushed the dropzone-multiple-uploads branch from a204ffc to d6bf015 Compare December 1, 2025 12:12
Kocal and others added 3 commits December 2, 2025 08:12
This PR was merged into the 2.x branch.

Discussion
----------

 Git-ignore config/reference.php

| Q              | A
| -------------- | ---
| Bug fix?       | yes
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Since symfony/symfony#62129, a new file `config/reference.php` can be generated when running tests locally.

This file must not be commited.

Commits
-------

74fd8da Git-ignore config/reference.php
Kocal and others added 30 commits December 12, 2025 03:39
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

[Site] Minor fixes before deployement

| Q              | A
| -------------- | ---
| Bug fix?       | yes
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Minor fixes before re-deploying the website.

Commits
-------

40b9346 [Site] Hide Toolkit from packages list
ff9fd53 [Site] Fix examples from Translator page
2ed9602 [Site] Update UX packages
This PR was merged into the 2.x branch.

Discussion
----------

 Add E2E tests for Autocomplete

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix symfony#3017 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Also added Foundry to create some entities when installing the E2E App.

Commits
-------

64d4336 Add E2E tests for Autocomplete
This PR was merged into the 2.x branch.

Discussion
----------

 Add E2E tests for LiveComponent

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix symfony#3021 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

This PR adds the following examples & associated tests. To resume, there are basic examples with LiveProp and LiveAction, advanced examples (form auto-validation & examples filtering), and advanced use-cases with the hydration/dehydration/serialization (to double-prevent some BCs from the past 🙈 )
<img width="1231" height="954" alt="image" src="https://github.com/user-attachments/assets/a6f2480d-3606-42de-938c-a29649efee73" />

Commits
-------

55e2ab2 Add E2E tests for LiveComponent
…us Stöhr)

This PR was merged into the 2.x branch.

Discussion
----------

[Toolkit][Shadcn] Add InputGroup component

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | yes <!-- required for new features, or documentation updates -->
| Issues         | Tracked in symfony#3233
| License        | MIT

Add InputGroup as a component.

ref: https://ui.shadcn.com/docs/components/input-group

Commits
-------

cbc7d04 feat(toolkit): add input-group component for shadcn kit
This PR was merged into the 2.x branch.

Discussion
----------

 Add E2E tests for Chart.js

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix symfony#3018 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

23e88a3 Add E2E tests for Chart.js
This PR was merged into the 2.x branch.

Discussion
----------

 Add E2E tests for Turbo

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix symfony#3027 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

76c87b8 Add E2E tests for Turbo
This PR was merged into the 2.x branch.

Discussion
----------

 Add E2E tests for CropperJS

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix symfony#3019 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

1ac8469 Add E2E tests for CropperJS
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.
…d UI logic for preview visibility and structure.
…coverage, and adjust styles.

# Conflicts:
#	src/Dropzone/assets/dist/controller.js
#	src/Dropzone/assets/src/controller.ts
#	src/Dropzone/assets/test/unit/controller.test.ts
#	src/Dropzone/assets/test/vitest.setup.js
#	src/Dropzone/assets/vitest.config.mjs
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.

# Conflicts:
#	src/Dropzone/CHANGELOG.md
#	src/Dropzone/assets/src/controller.ts
… files.

# Conflicts:
#	src/Dropzone/assets/src/controller.ts
…d UI logic for preview visibility and structure.

# Conflicts:
#	src/Dropzone/assets/test/unit/controller.test.ts
#	src/Dropzone/templates/form_theme.html.twig
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug Fix Deprecation Documentation Improvements or additions to documentation Feature New Feature Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dropzone] Multiple uploads only show single file and no possibility to add more files

6 participants