Skip to content

Conversation

@MasterPtato
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
rivet-cloud Ignored Ignored Dec 17, 2025 2:28am
rivet-inspector Ignored Ignored Preview Dec 17, 2025 2:28am
rivet-site Ignored Ignored Preview Dec 17, 2025 2:28am
rivetkit-serverless Skipped Skipped Dec 17, 2025 2:28am

@vercel vercel bot temporarily deployed to Preview – rivetkit-serverless December 17, 2025 02:28 Inactive
Copy link
Contributor Author

MasterPtato commented Dec 17, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Dec 17, 2025

PR Review: Grafana Dashboard Updates

Overview

This PR updates Grafana dashboard configurations across all Docker development environments. The changes are primarily formatting improvements and a critical SQL query fix.

Key Changes

1. Critical Bug Fix in traces.json ⚠️

Location: traces.json:728 (all environments)

Before:

$__conditionalAll(TraceId IN (${trace_id:singlequote}), $trace_id)

After:

TraceId IN array($trace_id), $trace_id)

Issues Found:

  • Syntax Error: The new SQL has a malformed WHERE clause with an extra , $trace_id) that does not belong
  • The replacement removes $__conditionalAll() but leaves trailing syntax
  • This will cause the dashboard to fail when rendering the "Errors by Service" panel

Expected Fix:

TraceId IN array($trace_id)

2. SQL Query Improvement in api.json

Location: api.json:1217 (all environments)

Before:

$__conditionalAll(Attributes[path], $path)

After:

Attributes[path] IN array($path)

This change is correct and improves the query by:

  • Removing Grafana macro in favor of explicit array syntax
  • More predictable behavior when filtering by path

3. JSON Formatting Changes

All environments now have consistent multi-line array formatting for better readability.

Issues to Address

🚨 BLOCKING: SQL Syntax Error

The traces.json SQL query modification has introduced a syntax error that will break the dashboard. The line contains an extra , $trace_id) that appears to be leftover from the find/replace operation.

Configuration Management Note

According to CLAUDE.md:

Do not make changes to docker/dev* configs. Instead, edit the template in docker/template/ and rerun regeneration.

Good: This PR correctly updates both template files and all generated environment configs consistently.

Recommendations

  1. Fix the SQL syntax error in traces.json line 728 (remove the trailing , $trace_id))
  2. Test the dashboards after deployment to ensure queries execute correctly
  3. Consider adding a validation step to catch SQL syntax errors in dashboard JSON files

Test Coverage

  • ⚠️ No tests included (dashboards are configuration files)
  • Manual testing of the Grafana dashboards should be performed after deployment

Summary

  • Approve after fix: The SQL syntax error in traces.json must be corrected before merging
  • Once fixed, the changes improve query clarity and JSON formatting consistency
  • No security concerns or performance issues beyond the broken query

Suggested action: Fix the SQL syntax error in the template file and regenerate the environment configs.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3655

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3655

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3655

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3655

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3655

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3655

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3655

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3655

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3655

commit: 36bd554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants