fix: update to eip 7594 blob handling #202
Draft
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlott
changed the title
dylanlott
changed the title
Member
|
isn't this already ticketed for @Evalir ? where are we at there? |
dylanlott
changed the title
dylanlott
changed the title
prestwich
requested changes
Dec 20, 2025
| let tx_envelope = sendable | ||
| .try_into_envelope()? | ||
| .try_into_7594() | ||
| .map_err(|e| eyre::eyre!("failed to map 4844 to 7594: {e:?}"))?; |
Member
There was a problem hiding this comment.
use wrap_err. The current code will erase context
| .try_into_envelope()? | ||
| .try_into_7594() | ||
| .map_err(|e| eyre::eyre!("failed to map 4844 to 7594: {e:?}"))?; | ||
| debug!(?tx_envelope, "prepared signed rollup block transaction envelope"); |
Member
There was a problem hiding this comment.
don't trace out the envelope, it'll be 100kb+ i think
| /// Encodes the sidecar and then builds the 4844 blob transaction from the provided header and signature values. | ||
| async fn build_blob_tx(&self) -> eyre::Result<TransactionRequest> { | ||
| /// Build the sidecar and input data for the transaction. | ||
| async fn build_sidecar_and_data(&self) -> eyre::Result<(BlobTransactionSidecar, Vec<u8>)> { |
Member
There was a problem hiding this comment.
let's break these into two functions rather than return s tuple
| .with_to(self.config.constants.host_zenith()) | ||
| .with_nonce(nonce); | ||
| debug!(?tx, "constructed rollup block transaction request"); | ||
|
|
Member
There was a problem hiding this comment.
don't trace the tx same reason as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update to eip 7594 blob handling
This PR changes the
prep_transactionto create a EIP-7594 compatible blob sidecar.Closes ENG-1582
Related to ENG-1562