Skip to content

Conversation

@heliang666s
Copy link
Member

What is the purpose of the change?

Support @ConditionalOnMissingBean for @DubboService #15814

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.78%. Comparing base (9fffe62) to head (8dafa89).

Files with missing lines Patch % Lines
...ory/annotation/ServiceAnnotationPostProcessor.java 13.63% 16 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15875   +/-   ##
=========================================
  Coverage     60.78%   60.78%           
  Complexity    11712    11712           
=========================================
  Files          1938     1938           
  Lines         88692    88714   +22     
  Branches      13387    13394    +7     
=========================================
+ Hits          53915    53929   +14     
- Misses        29256    29258    +2     
- Partials       5521     5527    +6     
Flag Coverage Δ
integration-tests-java21 32.38% <0.00%> (+0.01%) ⬆️
integration-tests-java8 32.44% <0.00%> (-0.01%) ⬇️
samples-tests-java21 32.08% <0.00%> (+0.02%) ⬆️
samples-tests-java8 29.74% <0.00%> (+0.01%) ⬆️
unit-tests-java11 59.07% <13.63%> (+<0.01%) ⬆️
unit-tests-java17 58.59% <13.63%> (+0.01%) ⬆️
unit-tests-java21 58.57% <13.63%> (+0.01%) ⬆️
unit-tests-java25 58.52% <13.63%> (-0.02%) ⬇️
unit-tests-java8 59.06% <13.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw
Copy link
Contributor

zrlw commented Dec 18, 2025

add test cases to check its effectiveness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants