fix(youtube-player): apply startSeconds with disablePlaceholder and autoplay #32570
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utoplay Fixes a bug where the YouTube player ignored the startSeconds input when both disablePlaceholder and playerVars.autoplay were set. The player now correctly seeks to the specified start time using seekTo() when the video autoplays. The issue occurred because the code only checked the playVideo parameter to determine if seekTo should be called, but didn't account for videos that autoplay through playerVars.autoplay = 1. Fixes angular#32545
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the YouTube player ignores the
startSecondsinput when bothdisablePlaceholderandplayerVars.autoplayare set.Problem
When using the YouTube player with:
disablePlaceholder="true"playerVars="{autoplay: 1}"startSeconds="N"(any non-zero value)The video would autoplay but start from the beginning (0 seconds) instead of the specified start time.
Solution
Modified the condition in
_createPlayer()to check forplayerVars.autoplay === 1in addition to theplayVideoparameter. When the player is already playing (from autoplay), it now correctly usesseekTo()to jump to the specifiedstartSeconds.Changes
src/youtube-player/youtube-player.tsto check for autoplay in playerVarssrc/youtube-player/youtube-player.spec.tsto validate the fixTesting
Related Issue
Fixes #32545