Better Sorting for many lists with Representations (#257)

Author: Strehk

src/lib/components/voting/RollCallVotingChair.svelte

@@ -28,9 +28,7 @@
 
 	let members = committee?.members
 		.filter((member) => member.present && member.representation?.type === 'DELEGATION')
-		.sort((a, b) =>
-			sortTranslatedCountries(a.representation!.alpha3Code!, b.representation!.alpha3Code!)
-		);
+		.sort((a, b) => sortTranslatedCountries(a.representation!, b.representation!));
 
 	let majorityAmount = $derived.by(() => {
 		switch (majority) {

src/lib/utils/nationTranslationHelper.svelte.ts

@@ -315,8 +315,12 @@ export const getTranslatedCountryNameFromAlpha3Code = (alpha3Code?: string | nul
 	return 'N/A';
 };
 
-export const sortTranslatedCountries = (alpha3CodeA: string, alpha3CodeB: string) => {
-	return getTranslatedCountryNameFromAlpha3Code(alpha3CodeA).localeCompare(
-		getTranslatedCountryNameFromAlpha3Code(alpha3CodeB)
+export const sortTranslatedCountries = (
+	a: { alpha3Code?: string | null; name?: string | null; [key: string]: any },
+	b: { alpha3Code?: string | null; name?: string | null; [key: string]: any }
+) => {
+	if (!a.alpha3Code || !a.name || !b.alpha3Code || !b.name) return 0;
+	return (a.name ?? getTranslatedCountryNameFromAlpha3Code(a.alpha3Code)).localeCompare(
+		b.name ?? getTranslatedCountryNameFromAlpha3Code(b.alpha3Code)
 	);
 };

src/routes/app/[conferenceId]/[committeeId]/(chairs)/presence/+page.svelte

@@ -32,9 +32,7 @@
 	let countries = $derived(
 		committee?.members
 			.filter((member) => member.representation?.type === 'DELEGATION')
-			.sort((a, b) =>
-				sortTranslatedCountries(a.representation!.alpha3Code!, b.representation!.alpha3Code!)
-			) ?? []
+			.sort((a, b) => sortTranslatedCountries(a.representation!, b.representation!)) ?? []
 	);
 
 	let nsas = $derived(

src/routes/app/[conferenceId]/[committeeId]/(presentation)/+page.svelte

@@ -174,9 +174,7 @@
 		committeeId={data.committeeId}
 		members={committee.members
 			.filter((x) => x.representation?.type === 'DELEGATION')
-			.sort((a, b) =>
-				sortTranslatedCountries(a.representation!.alpha3Code!, b.representation!.alpha3Code!)
-			)}
+			.sort((a, b) => sortTranslatedCountries(a.representation!, b.representation!))}
 	/>
 
 	<ShowOfHandsVotingPresentation committeeSettings={$committeeSettings} />